Re: [PATCH net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG
From: Thomas Bogendoerfer
Date: Mon Aug 26 2024 - 06:17:31 EST
On Mon, 26 Aug 2024 11:41:19 +0200
Jiri Pirko <jiri@xxxxxxxxxxx> wrote:
> Mon, Aug 26, 2024 at 10:58:30AM CEST, tbogendoerfer@xxxxxxx wrote:
> >For PFs, which don't support SRIOV_LAG, there is no pf->lag struct
> >allocated. So before accessing pf->lag a NULL pointer check is needed.
> >
> >Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@xxxxxxx>
>
> You need to add a "fixes" tag blaming the commit that introduced the
> bug.
of course...
Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on
bonded interface")
Should I resend the patch ?
Thomas.
--
SUSE Software Solutions Germany GmbH
HRB 36809 (AG Nürnberg)
Geschäftsführer: Ivo Totev, Andrew McDonald, Werner Knoblich