Re: [PATCH 2/2] gpio: Add G7 Aspeed gpio controller driver

From: Markus Elfring
Date: Mon Aug 26 2024 - 06:57:38 EST



> +++ b/drivers/gpio/gpio-aspeed-g7.c
> @@ -0,0 +1,831 @@

> +static void aspeed_gpio_g7_set(struct gpio_chip *gc, unsigned int offset, int val)
> +{

> + raw_spin_lock_irqsave(&gpio->lock, flags);
> +
> + __aspeed_gpio_g7_set(gc, offset, val);
> +
> + raw_spin_unlock_irqrestore(&gpio->lock, flags);
> +}


Under which circumstances would you become interested to apply a statement
like “guard(raw_spinlock_irqsave)(&gpio->lock);”?
https://elixir.bootlin.com/linux/v6.11-rc5/source/include/linux/spinlock.h#L551

Regards,
Markus