Re: [PATCH] cachefiles: fix dentry leak in cachefiles_open_file()

From: Markus Elfring
Date: Mon Aug 26 2024 - 09:56:28 EST



> Add the missing dput() to cachefiles_open_file() for a quick fix.

I suggest to use a goto chain accordingly.



> +++ b/fs/cachefiles/namei.c
> @@ -554,6 +554,7 @@ static bool cachefiles_open_file(struct cachefiles_object *object,
> if (!cachefiles_mark_inode_in_use(object, d_inode(dentry))) {
> pr_notice("cachefiles: Inode already in use: %pd (B=%lx)\n",
> dentry, d_inode(dentry)->i_ino);
> + dput(dentry);
> return false;

Please replace two statements by the statement “goto put_dentry;”.



> error:
> cachefiles_do_unmark_inode_in_use(object, d_inode(dentry));
+put_dentry:
> dput(dentry);
> return false;
> }

Regards,
Markus