Re: [PATCH 2/3] drivers: gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support

[Andrew Lunn]

> +static inline int siul2_get_gpio_pinspec(struct platform_device *pdev,
> +					 struct of_phandle_args *pinspec,
> +					 unsigned int range_index)
> +{
> +	struct device_node *np = pdev->dev.of_node;
> +
> +	return of_parse_phandle_with_fixed_args(np, "gpio-ranges", 3,
> +						range_index, pinspec);
> +}

In general, inline should be avoided. The compiler is better at
deciding than humans.

	Andrew