Re: [PATCH] perf hist: Don't set hpp_fmt_value for members in --no-group

[Arnaldo Carvalho de Melo]

On Wed, Aug 21, 2024 at 05:38:45PM -0700, Namhyung Kim wrote:
> Hi Kan,
> 
> On Tue, Aug 20, 2024 at 11:31 AM <kan.liang@xxxxxxxxxxxxxxx> wrote:
> >
> > From: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> >
> > Perf crashes as below when applying --no-group
> >
> > perf record -e "{cache-misses,branches"} -b sleep 1
> > perf report --stdio --no-group
> > free(): invalid next size (fast)
> > Aborted (core dumped)
> >
> > In the __hpp__fmt(), only 1 hpp_fmt_value is allocated for the current
> > event when --no-group is applied. However, the current implementation
> > tries to assign the hists from all members to the hpp_fmt_value, which
> > exceeds the allocated memory.
> >
> > Fixes: 8f6071a3dce4 ("perf hist: Simplify __hpp_fmt() using hpp_fmt_data")
> > Signed-off-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> 
> Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks, applied to perf-tools-next,

- Arnaldo