Re: [PATCH net-next v3 1/3] phy: open_alliance_helpers: Add defines for link quality metrics

[Andrew Lunn]

On Mon, Aug 26, 2024 at 09:32:17AM -0700, Jakub Kicinski wrote:
> On Thu, 22 Aug 2024 13:59:37 +0200 Oleksij Rempel wrote:
> > Introduce a set of defines for link quality (LQ) related metrics in the
> > Open Alliance helpers. These metrics include:
> > 
> > - `oa_lq_lfl_esd_event_count`: Number of ESD events detected by the Link
> >   Failures and Losses (LFL).
> > - `oa_lq_link_training_time`: Time required to establish a link.
> > - `oa_lq_remote_receiver_time`: Time required until the remote receiver
> >   signals that it is locked.
> > - `oa_lq_local_receiver_time`: Time required until the local receiver is
> >   locked.
> > - `oa_lq_lfl_link_loss_count`: Number of link losses.
> > - `oa_lq_lfl_link_failure_count`: Number of link failures that do not
> >   cause a link loss.
> > 
> > These standardized defines will be used by PHY drivers to report these
> > statistics.
> 
> If these are defined by a standard why not report them as structured
> data? Like we report ethtool_eth_mac_stats, ethtool_eth_ctrl_stats,
> ethtool_rmon_stats etc.?

We could do, but we have no infrastructure for this at the
moment. These are PHY statistics, not MAC statistics. We don't have
all the ethool_op infrastructure, etc. We also need to think about
which PHY do we want the statics from, the bootlin code for multiple
PHYs etc.

I will leave it up to Oleksij, but it would neatly avoid different
vendors returning the same stats with different names.

	Andrew