Re: [PATCH v2 1/6] ACPI: ac: Use strscpy() instead of strcpy().
From: Rafael J. Wysocki
Date: Mon Aug 26 2024 - 13:15:10 EST
On Sun, Aug 4, 2024 at 2:34 PM Muhammad Qasim Abdul Majeed
<qasim.majeed20@xxxxxxxxx> wrote:
>
> Replace strcpy() with strscpy() in the ACPI ac driver.
> strcpy() has been deprecated because it is generally unsafe, so help to
> eliminate it from the kernel source.
>
> Link: https://github.com/KSPP/linux/issues/88
>
> Signed-off-by: Muhammad Qasim Abdul Majeed <qasim.majeed20@xxxxxxxxx>
> ---
> drivers/acpi/ac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> index 09a87fa222c7..ad1427a384e4 100644
> --- a/drivers/acpi/ac.c
> +++ b/drivers/acpi/ac.c
> @@ -213,8 +213,8 @@ static int acpi_ac_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> ac->device = adev;
> - strcpy(acpi_device_name(adev), ACPI_AC_DEVICE_NAME);
> - strcpy(acpi_device_class(adev), ACPI_AC_CLASS);
> + strscpy(acpi_device_name(adev), ACPI_AC_DEVICE_NAME);
> + strscpy(acpi_device_class(adev), ACPI_AC_CLASS);
>
> platform_set_drvdata(pdev, ac);
>
> --
Applied as 6.12 material with some subject and changelog edits along
with patches [2-4/6] and [6/6].
Patch [6/6] needs more work (I'll send a reply to it directly).
Thanks!