Re: [patch net-next v2] net: ethtool: fix unheld rtnl lock

From: Christophe Leroy
Date: Mon Aug 26 2024 - 13:24:38 EST


Hi Diogo,

Le 26/08/2024 à 19:00, Diogo Jahchan Koike a écrit :
[Vous ne recevez pas souvent de courriers de djahchankoike@xxxxxxxxx. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]

Hi Maxime

Thanks for the clarification, I missed that. Should I resend my first patch
or should I release the lock before every return (tbh, I feel like that may
lead to a lot of repeated code) and send a new patch?


Do not duplicate release lock before every return.

See https://docs.kernel.org/process/coding-style.html#centralized-exiting-of-functions

Christophe