Re: [net-next v4 4/5] net: stmmac: Add PCI driver support for BCM8958x

[Jitendra Vegiraju]

Hi Amit,
Thanks for the review comments.

On Thu, Aug 22, 2024 at 9:35 AM Amit Singh Tomar <amitsinght@xxxxxxxxxxx> wrote:
>
> Hi,
>
>
> > +{
> > +     int ret;
> > +     int i;
> nit: This can be merged into single line.

Thanks, I will fix it.

> > +err_disable_msi:
> > +     pci_free_irq_vectors(pdev);
> > +err_disable_device:
> > +     pci_disable_device(pdev);
> Shouldn't pcim_iounmap_region be called here to unmap and release PCI BARs?

My understanding is that for managed API calls pcim_iomap_regions(),
we don't need to do explicit clean up.
Please let me know if that's not the case.
Just realized that pci_disable_device() in cleanup is not required
since the driver is using pcim_enable_device().