Re: [PATCH -fixes] drivers: perf: Fix smp_processor_id() use in preemptible code

From: Alexandre Ghiti
Date: Mon Aug 26 2024 - 13:38:19 EST



On 26/08/2024 19:31, Nam Cao wrote:
On Mon, Aug 26, 2024 at 06:52:10PM +0200, Alexandre Ghiti wrote:
As reported in [1], the use of smp_processor_id() in
pmu_sbi_device_probe() must be protected by disabling the preemption, so
simple use get_cpu()/put_cpu() instead.

Reported-by: Nam Cao <namcao@xxxxxxxxxxxxx>
Closes: https://lore.kernel.org/linux-riscv/20240820074925.ReMKUPP3@xxxxxxxxxxxxx/ [1]
Signed-off-by: Alexandre Ghiti <alexghiti@xxxxxxxxxxxx>
Tested-by: Nam Cao <namcao@xxxxxxxxxxxxx>

I think this also needs:
Fixes: a8625217a054 ("drivers/perf: riscv: Implement SBI PMU snapshot function")


Indeed, thanks for the tag!



Best regards,
Nam

_______________________________________________
linux-riscv mailing list
linux-riscv@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-riscv