Re: [PATCH V4 net-next 06/11] net: hibmcge: Implement .ndo_start_xmit function

From: Jakub Kicinski
Date: Mon Aug 26 2024 - 14:50:31 EST


On Mon, 26 Aug 2024 16:12:53 +0800 Jijie Shao wrote:
> +static int hbg_napi_tx_recycle(struct napi_struct *napi, int budget)
> +{
> + struct hbg_ring *ring = container_of(napi, struct hbg_ring, napi);
> + struct hbg_priv *priv = ring->priv;
> + /* This smp_load_acquire() pairs with smp_store_release() in
> + * hbg_start_xmit() called in xmit process.
> + */
> + u32 ntu = smp_load_acquire(&ring->ntu);
> + struct hbg_buffer *buffer;
> + u32 ntc = ring->ntc;
> + int packet_done = 0;
> +
> + while (packet_done < budget) {
> + if (unlikely(hbg_queue_is_empty(ntc, ntu)))
> + break;
> +
> + /* make sure HW write desc complete */
> + dma_rmb();
> +
> + buffer = &ring->queue[ntc];
> + if (buffer->state != HBG_TX_STATE_COMPLETE)
> + break;
> +
> + hbg_buffer_free(buffer);
> + ntc = hbg_queue_next_prt(ntc, ring);
> + packet_done++;
> + };

unnecessary semicolon
--
pw-bot: cr