Re: [PATCH v2 -next 09/11] cgroup/cpuset: move v1 interfaces to cpuset-v1.c

From: Waiman Long
Date: Mon Aug 26 2024 - 15:47:37 EST



On 8/26/24 15:40, Tejun Heo wrote:
On Mon, Aug 26, 2024 at 03:30:14PM -0400, Waiman Long wrote:
...
Another alternative is to include cpuset-v1.c directly into cpuset.c like

#ifdef CONFIG_CPUSETS_V1
#include "cpuset-v1.c"
#else
   ....
#endif

Then you don't need to change the names and will not need cpuset-internal.h.
It is up to you to decide what you want to do.
FWIW, I'd prefer to have cpuset1_ prefixed functions declared in cpuset1.h
or something rather than including .c file.

Sure. Let's have "cpuset1_" prefix if it is v1 specific and "cpuset_" prefix if it is used by both v1 and v2. That applies only to newly exposed names.

Cheers,
Longman