Re: [PATCH][next] qlcnic: make read-only const array key static

[Jakub Kicinski]

On Thu, 22 Aug 2024 22:10:28 +0100 Colin Ian King wrote:
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> index bcef8ab715bf..5a91e9f9c408 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> @@ -2045,9 +2045,11 @@ int qlcnic_83xx_config_rss(struct qlcnic_adapter *adapter, int enable)
>  	int err;
>  	u32 word;
>  	struct qlcnic_cmd_args cmd;
> -	const u64 key[] = { 0xbeac01fa6a42b73bULL, 0x8030f20c77cb2da3ULL,
> -			    0xae7b30b4d0ca2bcbULL, 0x43a38fb04167253dULL,
> -			    0x255b0ec26d5a56daULL };
> +	static const u64 key[] = {
> +		0xbeac01fa6a42b73bULL, 0x8030f20c77cb2da3ULL,
> +		0xae7b30b4d0ca2bcbULL, 0x43a38fb04167253dULL,
> +		0x255b0ec26d5a56daULL
> +	};

Move it up, please, reverse xmas tree
-- 
pw-bot: cr