Re: [PATCH v2 04/16] overlayfs: Document critical override_creds() operations

From: Vinicius Costa Gomes
Date: Mon Aug 26 2024 - 18:51:20 EST


Miklos Szeredi <miklos@xxxxxxxxxx> writes:

> On Thu, 22 Aug 2024 at 03:25, Vinicius Costa Gomes
> <vinicius.gomes@xxxxxxxxx> wrote:
>>
>> Add a comment to these operations that cannot use the _light version
>> of override_creds()/revert_creds(), because during the critical
>> section the struct cred .usage counter might be modified.
>
> Why is it a problem if the usage counter is modified? Why is the
> counter modified in each of these cases?
>

Working on getting some logs from the crash that I get when I convert
the remaining cases to use the _light() functions.

Perhaps I was wrong on my interpretation of the crash.

Thanks for raising this, I should have added more information about this.


Cheers,
--
Vinicius