Re: [PATCH v2 16/16] overlayfs: Remove ovl_override_creds_light()

[Vinicius Costa Gomes]

Miklos Szeredi <miklos@xxxxxxxxxx> writes:

> On Thu, 22 Aug 2024 at 03:25, Vinicius Costa Gomes
> <vinicius.gomes@xxxxxxxxx> wrote:
>>
>> Remove the declaration of this unsafe helper.
>>
>> As the GUARD() helper guarantees that the cleanup will run, it is less
>> error prone.
>
> This statement is somewhat dubious.
>
> I suggest that unless and until the goto issue can be fixed the
> conversion to guards is postponed.

That's a good point. I just want to point out that the issue is only
with the combination of the "plain" (not scoped) GUARD() statements and
'goto'.

But I would be happy to postpone that, if the trouble is not worth it.
As all the performance gains come from the conversion to the _light()
helpers.

>
> Thanks,
> Miklos

Cheers,
-- 
Vinicius