Re: [PATCH 1/2] dt-bindings: soc: rockchip: Fix compatibles for RK3588 VO{0,1}_GRF

From: Krzysztof Kozlowski
Date: Tue Aug 27 2024 - 02:57:19 EST


On Tue, Aug 27, 2024 at 02:06:50AM +0300, Cristian Ciocaltea wrote:
> According to RK3588 TRM, VO0_GRF and VO1_GRF have a similar layout, but
> definitely not an identical one, therefore sharing the compatible is not
> really justified.
>
> Since currently there is no user of this, hence no ABI break, let's fix
> it by providing dedicated strings.
>
> Reported-by: Conor Dooley <conor@xxxxxxxxxx>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> index 78c6d5b64138..8fd539125f4a 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> @@ -31,7 +31,8 @@ properties:
> - rockchip,rk3588-pcie3-pipe-grf
> - rockchip,rk3588-usb-grf
> - rockchip,rk3588-usbdpphy-grf
> - - rockchip,rk3588-vo-grf

You should deprecate the old one instead (deprecated: true).

Best regards,
Krzysztof