RE: [PATCH net-next v28 07/13] rtase: Implement a function to receive packets

[Larry Chiu]

> > +
> > +             skb = build_skb(ring->data_buf[entry], PAGE_SIZE);
> > +             if (!skb) {
> > +                     netdev_err(dev, "skb build failed\n");
> 
> I'm sorry for this late feedback, but the above message should be
> dropped, too.
> 
> As pointed out by Jakub in the previous revision, this allocation can
> fail, and the counter increase below will give exactly the same amount
> of information, without potentially filling the dmseg buffer.
> 
> FWIW, I think the above is the last item pending.
> 
> Thanks,
> 
> Paolo

Thank you for taking the time to review.
We will remove it in the next version.

Larry