Re: [PATCH] kernel/ext4: nested locking for xattr inode

From: Theodore Ts'o
Date: Tue Aug 27 2024 - 08:48:40 EST



On Thu, 01 Aug 2024 16:38:27 +0200, Wojciech Gładysz wrote:
> Add nested locking with I_MUTEX_XATTR subclass to avoid lockdep warning
> while handling xattr inode on file open syscall at ext4_xattr_inode_iget.
>
> Backtrace
> EXT4-fs (loop0): Ignoring removed oldalloc option
> ======================================================
> WARNING: possible circular locking dependency detected
> 5.10.0-syzkaller #0 Not tainted
> ------------------------------------------------------
> syz-executor543/2794 is trying to acquire lock:
> ffff8880215e1a48 (&ea_inode->i_rwsem#7/1){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:782 [inline]
> ffff8880215e1a48 (&ea_inode->i_rwsem#7/1){+.+.}-{3:3}, at: ext4_xattr_inode_iget+0x42a/0x5c0 fs/ext4/xattr.c:425
>
> [...]

Applied, thanks!

[1/1] kernel/ext4: nested locking for xattr inode
commit: d1bc560e9a9c78d0b2314692847fc8661e0aeb99

Best regards,
--
Theodore Ts'o <tytso@xxxxxxx>