Re: [PATCH 1/5] dt-bindings: phy: Add STM32MP25 COMBOPHY bindings

From: Krzysztof Kozlowski
Date: Tue Aug 27 2024 - 09:26:46 EST


On 27/08/2024 14:24, Christian Bruel wrote:
> Document the bindings for STM32 COMBOPHY interface, used to support
> the PCIe and USB3 stm32mp25 drivers.
> Following entries can be used to tune caracterisation parameters
> - st,output-micro-ohms and st,output-vswing-microvolt bindings entries
> to tune the impedance and voltage swing using discrete simulation results
> - st,rx-equalizer register to set the internal rx equalizer filter value.
>
> Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> Signed-off-by: Christian Bruel <christian.bruel@xxxxxxxxxxx>

v1? Or v3?

> ---
> .../bindings/phy/st,stm32-combophy.yaml | 144 ++++++++++++++++++
> 1 file changed, 144 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/st,stm32-combophy.yaml
>
> diff --git a/Documentation/devicetree/bindings/phy/st,stm32-combophy.yaml b/Documentation/devicetree/bindings/phy/st,stm32-combophy.yaml
> new file mode 100644
> index 000000000000..c33a843b83a3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/st,stm32-combophy.yaml

Filename matching compatible.

> @@ -0,0 +1,144 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/phy/st,stm32-combophy.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STM32MP25 USB3/PCIe COMBOPHY
> +
> +maintainers:
> + - Christian Bruel <christian.bruel@xxxxxxxxxxx>
> +
> +description:
> + Single lane PHY shared (exclusive) between the USB3 and PCIe controllers.
> + Supports 5Gbit/s for USB3 and PCIe gen2 or 2.5Gbit/s for PCIe gen1.
> +
> +properties:
> + compatible:
> + const: st,stm32mp25-combophy
> +
> + reg:
> + maxItems: 1
> +
> + "#phy-cells":
> + const: 1
> + description: |
> + The cells contain the following arguments.
> +
> + - description: The PHY type

That's some sort of mess. Is it schema within description or schema? Why
two descriptions?

> + enum:
> + - PHY_TYPE_USB3
> + - PHY_TYPE_PCIE
> +

...

> +required:
> + - compatible
> + - reg
> + - st,syscfg
> + - '#phy-cells'
> + - resets
> + - reset-names
> + - clocks
> + - clock-names
> +
> +allOf:
> + - if:
> + required:
> + - wakeup-source
> + then:
> + anyOf:
> + - required: [interrupts]
> + - required: [interrupts-extended]
> +

I do not see any improvements.

The tag you received was CONDITIONAL. If you do not apply the comments,
you cannot just apply the tag.

Best regards,
Krzysztof