Re: [PATCH 1/3] net: hisilicon: hip04: fix OF node leak in probe()

[Krzysztof Kozlowski]

On 27/08/2024 16:40, Simon Horman wrote:
> On Sun, Aug 25, 2024 at 09:21:31PM +0200, Markus Elfring wrote:
>>> Driver is leaking OF node reference from
>>> of_parse_phandle_with_fixed_args() in probe().
>>
>> * Is there a need to improve such a change description another bit?
>>
>>   + Imperative mood
>>
>>   * Tags like “Fixes” and “Cc”
> 
> I think it would be helpful if these were either explicitly targeted for
> net-next without Fixes tags (the assumed state of affairs as-is).
> 
> 	Subject: [Patch x/n net-next] ...
> 
> Or targeted at net, with Fixes tags
> 
> 	Subject: [Patch x/n net] ...
> 
> I guess that in theory these are fixes, as resource leaks could occur.
> But perhaps that is more theory that practice. I am unsure.

I'll resend with net-next.


Best regards,
Krzysztof