Re: [PATCH v3 7/8] arm64: dts: renesas: r9a09g057h44-gp-evk: Enable OSTM, I2C, and SDHI

[Lad, Prabhakar]

Hi Geert,

Thank you for the review.

On Mon, Aug 26, 2024 at 1:49 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Wed, Aug 21, 2024 at 10:56 AM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Enable OSTM0-OSTM7, RIIC{0,1,2,3,6,7,8}, and SDHI1 (available on the SD2
> > connector) on the RZ/V2H GP-EVK platform.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > ---
> > note, for i2c nodes we are defaulting the clock-frequency and this
> > will be updated when slave nodes are enabled.
>
> This causes lots of "'clock-frequency' is a required property" warnings
> from "make dtbs".  Moreover, what if I run i2cdetect on any of these
> buses? Could it run the bus faster than the board wiring allows?
> Hence I think you should add "clock-frequency" properties to all
> enabled I2C bus nodes.
>
OK, I will set the clock-frequency property for all the enabled i2c
buses to 400K.

Cheers,
Prabhakar