Re: [PATCH -next] md/raid1: cleanup local variable 'b' from radi1_read_request()

From: Song Liu
Date: Tue Aug 27 2024 - 13:10:23 EST


On Thu, Aug 1, 2024 at 6:33 AM Yu Kuai <yukuai1@xxxxxxxxxxxxxxx> wrote:
>
> From: Yu Kuai <yukuai3@xxxxxxxxxx>
>
> The local variable will only be used onced, in the error path that
> read_balance() failed to find a valid rdev to read. Since now the rdev
> is ensured can't be removed from conf while IO is still pending,
> remove the local variable and dereference rdev directly.
>
> Since we're here, also remove an extra empty line, and unnecessary
> type conversion from sector_t(u64) to unsigned long long.
>
> Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>

Applied to md-6.12. Thanks!
Song