Re: [PATCH v10 1/3] usb: gadget: function: move u_f.h to include/linux/usb/func_utils.h

[Michael Grzeschik]

On Tue, Aug 27, 2024 at 06:46:39PM +0200, Christophe JAILLET wrote:
> Le 26/08/2024 à 23:47, Michael Grzeschik a écrit :
> > We move the func_utils.h header to include/linux/usb to be
> > able to compile function drivers outside of the
> > drivers/usb/gadget/function directory.
> >
> > Signed-off-by: Michael Grzeschik <m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@xxxxxxxxxxxxxxxx>
> >
> > ---
> > v9 -> v10:
> >   - respect alphabetical order
> >   - correctly changed filename in func_utils.h itself
>
> ...
>
> > index e313c3b8dcb19..e7b69e3145c07 100644
> > --- a/drivers/usb/gadget/u_f.h
> > +++ b/include/linux/usb/func_utils.h
> > @@ -1,6 +1,6 @@
> >  // SPDX-License-Identifier: GPL-2.0
> >  /*
> > - * u_f.h
> > + * func_utils.h
> >   *
> >   * Utility definitions for USB functions
> >   *
>
> Maybe the include guard could be updated as-well?
>
> By include guard I mean:
>
> 	#ifndef __U_F_H__
> 	#define __U_F_H__
> 	...
> 	#endif /* __U_F_H__ */
>
> s/__U_F_H__/_FUNC_UTILS_H_/ or something like that.
>
> CJ

Doh! I missed that but will spin another round!

Thanks,
Michael



--
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature