Re: [PATCH] clk: Delete init for local variable "best_crent_rate".

From: Stephen Boyd
Date: Tue Aug 27 2024 - 13:40:18 EST


Quoting jiping huang (2024-08-27 10:21:10)
> I'm sorry, my last submission may not expressed it clearly, and there \
> is an error delete. Therefore, I would like to generate a new patch and \
> explanations.
> Actually, it is, the local variable 'best_crent_rate' is only used in \
> line 2355 for the judgment 'best_crent_rate!=parent ->rate'. However, \
> if the "if (clk_core_can_round (core))" branch condition in line 2306 \
> is true, the value of the local variable "best_crent_rate" will be \
> updated by "best_crent_rate=req.best_crent_rate;" in line 2319, otherwise \
> it will be directly returned in the "else if" branch in line 2325 and the \
> "else" branch in line 2329.
> In summary, it is unnecessary to store the "parent ->rate" value in \
> "best_crent_rate" in line 2301.
> Thank you for your precious time!

Please read the docs on how to submit patches. Especially the part about
describing your change[1]. For example, "best_crent_rate" doesn't exist.
Also, look at other commits for guidance on how to write your commit
text. Thanks!

[1] https://docs.kernel.org/process/submitting-patches.html#describe-your-changes