On Tue, 2024-08-06 at 12:08 -0600, Gustavo A. R. Silva wrote:
+++ b/include/net/ieee80211_radiotap.h
@@ -24,31 +24,36 @@
* struct ieee80211_radiotap_header - base radiotap header
*/
struct ieee80211_radiotap_header {
- /**
- * @it_version: radiotap version, always 0
- */
- uint8_t it_version;
-
- /**
- * @it_pad: padding (or alignment)
- */
- uint8_t it_pad;
-
- /**
- * @it_len: overall radiotap header length
- */
- __le16 it_len;
-
- /**
- * @it_present: (first) present word
- */
- __le32 it_present;
+ /* New members MUST be added within the __struct_group() macro below. */
There cannot be new members without breaking interop with the radiotap
spec, that comment isn't really useful ;-)
+ __struct_group(ieee80211_radiotap_header_hdr, hdr, __packed,
And also, "header header" sounds odd to me really. The header of the
header? What's what?
I think perhaps better to call this ieee80211_radiotap_hdr_fixed or so?