Re: [PATCH v4 1/2] platform/x86:dell-laptop: Add knobs to change battery charge settings

[Thomas Weißschuh]

On 2024-08-26 16:44:35+0000, Hans de Goede wrote:
> [..]

> Yes not being able to see the supported values is annoying I actually
> wrote an email about that earlier today:
> 
> https://lore.kernel.org/linux-pm/49993a42-aa91-46bf-acef-4a089db4c2db@xxxxxxxxxx/
> 
> but we need to make sure that the output is consistent between drivers otherwise
> userspace can never know how to use the API, so for charge_type the dell
> driver should only output the active type, not all the options.
> 
> This reminds me that there was a patch-series to allow battery extension drivers
> like this one to actually use the power-supply core code for show()/store()
> Thomas IIRC that series was done by you ?  What is the status of that ?

Yes, that is from me, [0].
At least I'll need to implement the feedback from Sebastian and a proper
locking scheme.
I still intend to work on it, but if there are other people waiting for
it, I'll try to get on with it.

In the meantime maybe the psy core could export a helper function for
formatting and parsing? Similar to the charge_behaviour helpers.

[0] https://lore.kernel.org/lkml/20240608-power-supply-extensions-v2-0-2dcd35b012ad@xxxxxxxxxxxxxx/