Re: [PATCH] LoongArch: Remove posix_types.h include from sigcontext.h

[Xi Ruoyao]

On Wed, 2024-08-28 at 12:11 +0800, Huacai Chen wrote:
> Hi, Ruoyao,
> 
> Just some questions:
> 1, Changing UAPI is not a good idea.

But removing unneeded includes from UAPI is fine.  For example, the
commit 44e0b165b6c078b84767da4ba06ffa27af562c96 has removed
linux/posix_types.h from termbits.h for all ports.

> 2. In another thread you said that "paper over" is not enough for some
> cases.
> 3. include/uapi/linux/types.h still include linux/posix_types.h, why
> your "paper over" works?

Well maybe it does not work (I've not seriously tested as it's just a
paper over).  But removing unneeded include is correct on its own
anyway.  And ...

> > The unneeded include was found debugging some vDSO self test build
> > failure (it's not the root cause though).

So it's just "found" debugging the issue.  Maybe I should change "it's
not the root cause" to "it's not really related to that issue"?
> 

-- 
Xi Ruoyao <xry111@xxxxxxxxxxx>
School of Aerospace Science and Technology, Xidian University