Re: [PATCH v3 1/2] dt-bindings: mtd: nuvoton,ma35d1-nand: add new bindings

[Hui-Ping Chen]

Dear Miquel,

Thank you for your reply.



On 2024/8/28 下午 03:48, Miquel Raynal wrote:
> Hi Hui-Ping,
>
> hpchen0nvt@xxxxxxxxx wrote on Wed, 28 Aug 2024 10:47:17 +0800:
>
> > Dear Miquèl,
> >
> > Thank you for your reply.
> >
> >
> >
> > On 2024/8/24 上午 12:26, Miquel Raynal wrote:
> > > Hi,
> > >
> > > hpchen0nvt@xxxxxxxxx wrote on Wed, 21 Aug 2024 07:11:31 +0000:
> > >   
> > > > Add dt-bindings for the Nuvoton MA35 SoC NAND Controller.
> > > >
> > > > Signed-off-by: Hui-Ping Chen <hpchen0nvt@xxxxxxxxx>
> > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > > > ---
> > > >    .../bindings/mtd/nuvoton,ma35d1-nand.yaml     | 93 +++++++++++++++++++
> > > >    1 file changed, 93 insertions(+)
> > > >    create mode 100644 Documentation/devicetree/bindings/mtd/nuvoton,ma35d1-nand.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/mtd/nuvoton,ma35d1-nand.yaml b/Documentation/devicetree/bindings/mtd/nuvoton,ma35d1-nand.yaml
> > > > new file mode 100644
> > > > index 000000000000..152784e73263
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/mtd/nuvoton,ma35d1-nand.yaml
> > > > @@ -0,0 +1,93 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/mtd/nuvoton,ma35d1-nand.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Nuvoton MA35D1 NAND Flash Interface (NFI) Controller
> > > > +
> > > > +maintainers:
> > > > +  - Hui-Ping Chen <hpchen0nvt@xxxxxxxxx>
> > > > +
> > > > +allOf:
> > > > +  - $ref: nand-controller.yaml#
> > > > +
> > > > +properties:
> > > > +  compatible:
> > > > +    enum:
> > > > +      - nuvoton,ma35d1-nand
> > > Can we please use the -nand-controller suffix. A NAND is a the common
> > > name for a chip with storage inside. You are describing a host
> > > controller that can be connected to in order to talk to a NAND.
> >
> > Okay, I will change it to nuvoton,ma35d1-nfi.
> >
> > Because in our platform, it is the NAND Flash Interface.
> nfi is not an acronym that is understandable by everyone. Please use
> -nand-controller. Don't be worried by the size of the string.
>
> You can use the acronym as prefix for your NAND controller functions
> though.

Okay, I will change it to nuvoton,ma35d1-nand-controller.



> Thanks,
> Miquèl


Best regards,

Hui-Ping Chen