Re: [PATCH v2] x86/EISA: Use memremap() to probe for the EISA BIOS signature

[Maciej W. Rozycki]

On Wed, 28 Aug 2024, Christoph Hellwig wrote:

> > +	if (p && *p == 'E' + ('I' << 8) + ('S' << 16) + ('A' << 24))
> 
> Should this simply use strcmp now?

 It's not an ASCIIZ string, so I guess memcmp() instead.  I can see there 
is still no clarity as to whether memremap() is enough here (though it 
escapes me why it wouldn't, given that early_memremap() analogously works 
for the MP-table with the scenarios in question), so I'll let things 
settle and look into an update once I'm back from my holiday next week.

 NB sparse chokes on some headers' contents here, so it seems I can't 
really make use of it without figuring out what's wrong first.

  Maciej