Re: [PATCH net-next 6/6] net: ethernet: fs_enet: phylink conversion

From: Russell King (Oracle)
Date: Wed Aug 28 2024 - 06:48:22 EST


On Wed, Aug 28, 2024 at 11:51:02AM +0200, Maxime Chevallier wrote:
> +static int fs_eth_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
> +{
> + struct fs_enet_private *fep = netdev_priv(dev);
> +
> + if (!netif_running(dev))
> + return -EINVAL;

Why do you need this check?

--
*** please note that I probably will only be occasionally responsive
*** for an unknown period of time due to recent eye surgery making
*** reading quite difficult.

RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!