Re: [PATCH net-next v2 07/13] net: mdio: mux-mmioreg: Simplified with scoped function

From: Jonathan Cameron
Date: Wed Aug 28 2024 - 08:46:49 EST


On Wed, 28 Aug 2024 11:23:37 +0800
Jinjie Ruan <ruanjinjie@xxxxxxxxxx> wrote:

> Avoids the need for manual cleanup of_node_put() in early exits
> from the loop by using for_each_available_child_of_node_scoped().
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>
Looks fine, though maybe driver would also benefit from dev_err_probe()
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>