Re: [PATCH v13 3/5] dt-bindings: net: wireless: brcm4329-fmac: change properties enum structure

From: Jacobe Zang
Date: Wed Aug 28 2024 - 09:20:57 EST




On 2024/8/28 21:04, Krzysztof Kozlowski wrote:
On 28/08/2024 10:49, Jacobe Zang wrote:
Add "brcm,bcm4329-fmac" as fallback compatible for wireless devices that
used PCI ID based compatible. So that can pass the compatible check in
driver.

Driver? Why this has to pass compatible check?

I think I asked to provide proper rationale based on hardware... if not,
then let me ask here: Please provide proper rationale explaining how
this hardware is compatible, especially considering these are entirely
different buses (SDIO and PCI!).

It feels you patch up bindings and DTS, because of buggy driver. Sorry
no, fix the driver.


All right. Anyway after discussion in the other series, this patch should be dropped, and driver also need to fix.

--
Best Regards
Jacobe