Re: [PATCH] x86/tdx: Enhance code generation for TDCALL and SEAMCALL wrappers
From: Edgecombe, Rick P
Date: Wed Aug 28 2024 - 09:35:14 EST
On Tue, 2024-06-04 at 12:34 -0700, Sean Christopherson wrote:
>
> If we're willing to suffer a few gnarly macros, I think we get a satisfactory
> mix
> of standardized arguments and explicit operands, and generate vastly better
> code.
Hi Sean,
We are kind of stuck on improving the code generation for the existing calls.
x86 maintainers don't seem to be enthusiastic about tackling this urgently and
there is not consensus on how to weigh source code clarity with code generation
sanity [0]. I think we are going to table it for the time being, unless it's a
showstopper for you.
An option is still to have a separate helper infrastructure for KVM's calls, but
as discussed originally this duplicates code.
Rick
[0] https://lore.kernel.org/all/3a210286-7d0f-4404-ad79-c8eab1514381@xxxxxxxxx/