Re: [PATCH] drm/tegra: hub: Use fn parameter directly to fix Coccinelle warning

From: Thierry Reding
Date: Wed Aug 28 2024 - 11:12:20 EST


On Wed, Jul 10, 2024 at 11:00:35PM GMT, Thorsten Blum wrote:
> The function parameter out can be used directly instead of assigning it
> to a temporary u64 variable first.
>
> Remove the local variable tmp2 and use the parameter out directly as the
> divisor in do_div() to remove the following Coccinelle/coccicheck
> warning reported by do_div.cocci:
>
> WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxxx>
> ---
> drivers/gpu/drm/tegra/hub.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)

Applied, thanks.

Thierry

Attachment: signature.asc
Description: PGP signature