Re: [PATCH v4 2/5] Coresight: Add trace_id function to retrieving the trace ID

[Markus Elfring]

…
> +++ b/drivers/hwtracing/coresight/coresight-sysfs.c
> @@ -168,6 +168,7 @@ int coresight_enable_sysfs(struct coresight_device *csdev)
>  	int cpu, ret = 0;
>  	struct coresight_device *sink;
>  	struct list_head *path;
> +	struct cs_sink_data *sink_data;
…

* How do you think about to use the attribute “__free(kfree)” at more places accordingly?
  https://elixir.bootlin.com/linux/v6.11-rc5/source/include/linux/slab.h#L282

* Would you like to reduce the scope for such a local variable?


Regards,
Markus