Re: [PATCH] perf test trace_btf_enum: Fix shellcheck warning

From: Arnaldo Carvalho de Melo
Date: Wed Aug 28 2024 - 17:19:15 EST


On Fri, Aug 09, 2024 at 10:54:22AM +0100, James Clark wrote:
> Shellcheck versions < v0.7.2 can't follow this path so add the helper to
> fix the following warning:
>
> In tests/shell/trace_btf_enum.sh line 13:
> . "$(dirname $0)"/lib/probe.sh
> ^--------------------------^ SC1090: Can't follow non-constant source.
> Use a directive to specify location.

Thanks, applied to perf-tools-next,

- Arnaldo

> Fixes: d66763fed30f ("perf test trace_btf_enum: Add regression test for the BTF augmentation of enums in 'perf trace'")
> Signed-off-by: James Clark <james.clark@xxxxxxxxxx>
> ---
> tools/perf/tests/shell/trace_btf_enum.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/tests/shell/trace_btf_enum.sh b/tools/perf/tests/shell/trace_btf_enum.sh
> index 7d407b52bea5..5a3b8a5a9b5c 100755
> --- a/tools/perf/tests/shell/trace_btf_enum.sh
> +++ b/tools/perf/tests/shell/trace_btf_enum.sh
> @@ -10,6 +10,7 @@ non_syscall="timer:hrtimer_init,timer:hrtimer_start"
>
> TESTPROG="perf test -w landlock"
>
> +# shellcheck source=lib/probe.sh
> . "$(dirname $0)"/lib/probe.sh
> skip_if_no_perf_trace || exit 2
>
> --
> 2.34.1