Re: [PATCH v2 2/2] staging: rtl8712: Calculate size from pointer

From: Manisha Singh
Date: Wed Aug 28 2024 - 17:32:11 EST



On 8/29/24 02:45, Philipp Hortmann wrote:
On 8/28/24 22:45, Manisha Singh wrote:
Calculate the size from the pointer instead of struct

Hi Manisha,

the first line of the description is good. Please just add the why (to adhere to kernel coding style?) and the "." to make it a full sentence.

Omit the next two lines.
CHECK: Prefer kmalloc(sizeof(*pintf_hdl->pintfpriv)...) over
kmalloc(sizeof(struct intf_priv)...)


Thanks for your support.

Bye Philipp

Sure, will do that.

Thanks for reviewing.

Manisha