Re: [PATCH] mm/hugetlb: sort out global lock annotations

From: Andrew Morton
Date: Wed Aug 28 2024 - 17:39:08 EST


On Wed, 28 Aug 2024 23:02:39 +0200 Mateusz Guzik <mjguzik@xxxxxxxxx> wrote:

> > We'd need a new DEFINE_SPINLOCK_ALIGNED() or something.
> >
> > Ho hum, I'll fix.
>
> that would be a nice addition
>
> so as is this triviality grew to 3 patches which I consider rather
> extreme, and the middle one breaks the build
>
> In the vfs land this would get squashed into one commit with a
> maintainer note that some tweaking was performed, which I would
> suggest here

Yep. In mm land they get piled up as base+fix+fix-2 etc and then
squashed before being moved into mm.git's non-rebasing mm-stable
branch.

> alternatively, given the trivial nature of the entire thing, if you
> add DEFINE_SPINLOCK_ALIGNED and do the annotation tweak, you may as
> well commit this as your own patch. I don't need any credit

eh, it's very minor.