Re: [PATCH net-next] net: ag71xx: update FIFO bits and descriptions
From: Rosen Penev
Date: Wed Aug 28 2024 - 18:36:54 EST
On Wed, Aug 28, 2024 at 3:29 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Wed, 28 Aug 2024 13:42:49 -0700 Rosen Penev wrote:
> > Taken from QCA SDK. No functional difference as same bits get applied.
>
> Are these used? Would be nice to heave your best guess on the impact
> this change will have in the commit message, for posterity scanning
> git logs a few months/years from now.
No impact. It's effectively a documentation fix.
I see ag71xx_wr(ag, AG71XX_REG_FIFO_CFG5, FIFO_CFG5_INIT); so yes, they're used.
>
> BTW missing CC netdev, feel free to resend without 24h wait.
That's embarrassing. Will do.