Re: [PATCH 1/2] dmaengine: idxd: Add a new DSA device ID on Granite Rapids-D platform

[Dave Jiang]

On 8/28/24 3:42 PM, Fenghua Yu wrote:
> A new DSA device ID, 0x11fb, is introduced on the Granite Rapids-D
> platform. Add the device ID to the IDXD driver.
> 
> Since a potential security issue has been fixed on the new device, it's
> secure to assign the device to virtual machines, and therefore, the new
> device ID will not be added to the VFIO denylist. Additionally, the new
> device ID may be useful in identifying and addressing any other potential
> issues with this specific device in the future. The same is also applied
> to any other new DSA/IAA devices with new device IDs.
> 
> Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>

Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> ---
>  drivers/dma/idxd/init.c | 2 ++
>  include/linux/pci_ids.h | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
> index 21f6905b554d..415b17b0acd0 100644
> --- a/drivers/dma/idxd/init.c
> +++ b/drivers/dma/idxd/init.c
> @@ -69,6 +69,8 @@ static struct idxd_driver_data idxd_driver_data[] = {
>  static struct pci_device_id idxd_pci_tbl[] = {
>  	/* DSA ver 1.0 platforms */
>  	{ PCI_DEVICE_DATA(INTEL, DSA_SPR0, &idxd_driver_data[IDXD_TYPE_DSA]) },
> +	/* DSA on GNR-D platforms */
> +	{ PCI_DEVICE_DATA(INTEL, DSA_GNRD, &idxd_driver_data[IDXD_TYPE_DSA]) },
>  
>  	/* IAX ver 1.0 platforms */
>  	{ PCI_DEVICE_DATA(INTEL, IAX_SPR0, &idxd_driver_data[IDXD_TYPE_IAX]) },
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index e388c8b1cbc2..ff99047dac44 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2706,6 +2706,7 @@
>  #define PCI_DEVICE_ID_INTEL_82815_MC	0x1130
>  #define PCI_DEVICE_ID_INTEL_82815_CGC	0x1132
>  #define PCI_DEVICE_ID_INTEL_SST_TNG	0x119a
> +#define PCI_DEVICE_ID_INTEL_DSA_GNRD	0x11fb
>  #define PCI_DEVICE_ID_INTEL_82092AA_0	0x1221
>  #define PCI_DEVICE_ID_INTEL_82437	0x122d
>  #define PCI_DEVICE_ID_INTEL_82371FB_0	0x122e