Re: [PATCH] nfs: protect nfs41_impl_id by rcu
From: kernel test robot
Date: Wed Aug 28 2024 - 19:17:45 EST
Hi Li,
kernel test robot noticed the following build warnings:
[auto build test WARNING on trondmy-nfs/linux-next]
[also build test WARNING on linus/master v6.11-rc5 next-20240828]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Li-Lingfeng/nfs-protect-nfs41_impl_id-by-rcu/20240828-124056
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
patch link: https://lore.kernel.org/r/20240828044933.676898-1-lilingfeng3%40huawei.com
patch subject: [PATCH] nfs: protect nfs41_impl_id by rcu
config: x86_64-randconfig-121-20240829 (https://download.01.org/0day-ci/archive/20240829/202408290616.QG17h6tl-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240829/202408290616.QG17h6tl-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408290616.QG17h6tl-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
>> fs/nfs/nfs4client.c:296:18: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const *objp @@ got struct nfs41_impl_id [noderef] __rcu *cl_implid @@
fs/nfs/nfs4client.c:296:18: sparse: expected void const *objp
fs/nfs/nfs4client.c:296:18: sparse: got struct nfs41_impl_id [noderef] __rcu *cl_implid
vim +296 fs/nfs/nfs4client.c
ec409897e7c715 Bryan Schumaker 2012-07-16 283
ec409897e7c715 Bryan Schumaker 2012-07-16 284 static void nfs4_shutdown_client(struct nfs_client *clp)
ec409897e7c715 Bryan Schumaker 2012-07-16 285 {
ec409897e7c715 Bryan Schumaker 2012-07-16 286 if (__test_and_clear_bit(NFS_CS_RENEWD, &clp->cl_res_state))
ec409897e7c715 Bryan Schumaker 2012-07-16 287 nfs4_kill_renewd(clp);
abf79bb341bf52 Chuck Lever 2013-08-09 288 clp->cl_mvops->shutdown_client(clp);
ec409897e7c715 Bryan Schumaker 2012-07-16 289 nfs4_destroy_callback(clp);
ec409897e7c715 Bryan Schumaker 2012-07-16 290 if (__test_and_clear_bit(NFS_CS_IDMAP, &clp->cl_res_state))
ec409897e7c715 Bryan Schumaker 2012-07-16 291 nfs_idmap_delete(clp);
ec409897e7c715 Bryan Schumaker 2012-07-16 292
ec409897e7c715 Bryan Schumaker 2012-07-16 293 rpc_destroy_wait_queue(&clp->cl_rpcwaitq);
ec409897e7c715 Bryan Schumaker 2012-07-16 294 kfree(clp->cl_serverowner);
ec409897e7c715 Bryan Schumaker 2012-07-16 295 kfree(clp->cl_serverscope);
ec409897e7c715 Bryan Schumaker 2012-07-16 @296 kfree(clp->cl_implid);
ceb3a16c070c40 Trond Myklebust 2015-01-03 297 kfree(clp->cl_owner_id);
ec409897e7c715 Bryan Schumaker 2012-07-16 298 }
ec409897e7c715 Bryan Schumaker 2012-07-16 299
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki