Re: [PATCH bpf-next v2 1/2] bpf: Relax KF_ACQUIRE kfuncs strict type matching constraint
From: patchwork-bot+netdevbpf
Date: Wed Aug 28 2024 - 20:20:45 EST
Hello:
This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@xxxxxxxxxx>:
On Wed, 28 Aug 2024 20:48:11 +0100 you wrote:
> Currently we cannot pass zero offset (implicit cast) or non-zero offset
> pointers to KF_ACQUIRE kfuncs. This is because KF_ACQUIRE kfuncs
> requires strict type matching, but zero offset or non-zero offset does
> not change the type of pointer, which causes the ebpf program to be
> rejected by the verifier.
>
> This can cause some problems, one example is that bpf_skb_peek_tail
> kfunc [0] cannot be implemented by just passing in non-zero offset
> pointers. We cannot pass pointers like &sk->sk_write_queue (non-zero
> offset) or &sk->__sk_common (zero offset) to KF_ACQUIRE kfuncs.
>
> [...]
Here is the summary with links:
- [bpf-next,v2,1/2] bpf: Relax KF_ACQUIRE kfuncs strict type matching constraint
https://git.kernel.org/bpf/bpf-next/c/f633919d132c
- [bpf-next,v2,2/2] selftests/bpf: Add test for zero offset or non-zero offset pointers as KF_ACQUIRE kfuncs argument
https://git.kernel.org/bpf/bpf-next/c/6db59c4935c9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html