Re: [PATCH V5 net-next 04/11] net: hibmcge: Add interrupt supported in this module

[Jijie Shao]

on 2024/8/29 9:35, Jakub Kicinski wrote:
> On Tue, 27 Aug 2024 21:14:48 +0800 Jijie Shao wrote:
> > +	ret = pci_alloc_irq_vectors(priv->pdev, HBG_VECTOR_NUM, HBG_VECTOR_NUM,
> > +				    PCI_IRQ_MSI | PCI_IRQ_MSIX);
> These are not devm_ -managed, don't you have to free them?
> On remove and errors during probe?
Jonathan Cameron told me:
	I have used pcim_enable(),  so, the irq vectors become device managed.
Look for where those paths call pci_setup_msi_context() / pcim_setup_msi_release()

So there should be no need to free the vectors on remove()

	Thanks，
	Jijie Shao