Re: [PATCH -next 2/8] soc: fsl: cpm1: Simplify with dev_err_probe()
From: Jinjie Ruan
Date: Wed Aug 28 2024 - 22:26:07 EST
On 2024/8/28 21:08, Krzysztof Kozlowski wrote:
> On 28/08/2024 03:58, Jinjie Ruan wrote:
>>
>>
>> On 2024/8/27 21:50, Krzysztof Kozlowski wrote:
>>> On 27/08/2024 13:46, Jinjie Ruan wrote:
>>>> Use the dev_err_probe() helper to simplify error handling during probe.
>>>> This also handle scenario, when EDEFER is returned and useless error
>>>> is printed.
>>>
>>> ? Sorry, this cannot happen. Please point to below code which can defer.
>>>
>>
>> Thank you!
>>
>> This is not referring to a specific one, but rather the benefits it
>> offers,simplify code is the main purpose, if necessary, it will be
>> removed in next version.
>
> It just feels like you are doing these in machine way without actually
> knowing concepts behind dev_err_probe().
Just try my best to make the code as clean as possible and do it by the way.
>
> Best regards,
> Krzysztof
>