Re: [PATCH v3] dma: Trace API

From: Christoph Hellwig
Date: Thu Aug 29 2024 - 00:19:22 EST


I'd change the subject to

dma-mapping: add tracing for dma-mapping API calls

On Mon, Aug 26, 2024 at 04:32:40PM -0400, Sean Anderson wrote:
> When debugging drivers, it can often be useful to trace when memory gets
> (un)mapped for DMA (and can be accessed by the device). Add some
> tracepoints for this purpose.
>
> We use unsigned long long instead of phys_addr_t and dma_addr_t (and
> similarly %llx instead of %pa) because libtraceevent can't handle
> typedefs.

and a __u64 would seem like the better type here.

otherwise this looks fine to me. I can do the tweaks as I'll apply
the patch if needed.