Re: [net-next PATCH v7 1/8] octeontx2-pf: map skb data as device writeable

[Bharat Bhushan]

On Thu, Aug 29, 2024 at 6:51 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Tue, 27 Aug 2024 19:02:03 +0530 Bharat Bhushan wrote:
> > Crypto hardware need write permission for in-place encrypt
> > or decrypt operation on skb-data to support IPsec crypto
> > offload. That patch uses skb_unshare to make sdk data writeable
>
> sdk -> skb ? :(
Will fix in next version

>
> > for ipsec crypto offload and map skb fragment memory as
> > device read-write.
>
> Does the crypto engine always override the data with ciphertext?

yes,

> How did you test this prior to adding skb_unshare()?
> Could you share some performance data with this change?

testing using flood ping and iperf with multiple instance,
I do not see any drop in performance numbers

Thanks
-Bharat