Re: [PATCHv4 net-next] net: ag71xx: get reset control using devm api
From: Rosen Penev
Date: Thu Aug 29 2024 - 01:58:03 EST
On Wed, Aug 28, 2024 at 9:49 PM Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:
>
> On Mon, Aug 26, 2024 at 12:28:45PM -0700, Rosen Penev wrote:
> > Currently, the of variant is missing reset_control_put in error paths.
> > The devm variant does not require it.
> >
> > Allows removing mdio_reset from the struct as it is not used outside the
> > function.
> >
> > Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
>
> You forgot to include my Reviewed-by tags from v3
Correct. Although Jakub wants me to respin this removing that always
true branch.
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |