Re: [PATCH v1] sfc: Convert to use ERR_CAST()

From: Alejandro Lucero Palau
Date: Thu Aug 29 2024 - 02:48:19 EST



On 8/29/24 00:01, Jakub Kicinski wrote:
On Wed, 28 Aug 2024 15:31:08 -0700 Jacob Keller wrote:
Somewhat unrelated but you could cleanup some of the confusion by using
__free(kfree) annotation from <linux/cleanup.h> to avoid needing to
manually free ctr in error paths, and just use return_ptr() return the
value at the end.
Please don't send people towards __free(). In general, but especially as
part of random cleanups.


Hi Kuba,


Could you explain why or point to a discussion about it?

Thanks