Re: [PATCH] tools/mm: Use calloc and check the potential memory allocation failure

From: Dev Jain
Date: Thu Aug 29 2024 - 03:40:14 EST



On 8/29/24 11:55, Markus Elfring wrote:
Replace malloc with calloc and add memory allocating check
memset(…, 0, …) call by calloc()?

Calloc returns zeroed-out memory.



of comm_str before used.
* Add also a null pointer check for the detection of a memory allocation failure.

Which is exactly what Zhu has done?


* Would you like to improve such a change description another bit
(with tags like “Fixes” and “Cc”)?

* How do you think about to omit the statement “fprintf(stderr, "Out of memory\n");”?

Why?


* I suggest to omit the word “potential” from the summary phrase.


Regards,
Markus