Re: [PATCH v6 1/6] i3c: mipi-i3c-hci: Add AMDI5017 ACPI ID to the I3C Support List
From: Andy Shevchenko
Date: Thu Aug 29 2024 - 07:05:11 EST
On Thu, Aug 29, 2024 at 02:47:08PM +0530, Shyam Sundar S K wrote:
> The current driver code lacks the necessary plumbing for ACPI IDs,
> preventing the mipi-i3c-hci driver from being loaded on x86
> platforms that advertise I3C ACPI support.
>
> Add the AMDI5017 ACPI ID to the list of supported IDs.
...
> static struct platform_driver i3c_hci_driver = {
> .probe = i3c_hci_probe,
> .remove_new = i3c_hci_remove,
> .driver = {
> .name = "mipi-i3c-hci",
> .of_match_table = of_match_ptr(i3c_hci_of_match),
A side note (not sure if it anyhow might be related to your kernel
configurations and builds): There is an ongoing activity to kill
of_match_ptr() for good (as it's more harmful than useful). It _might_ be
that in ACPI only kernel configurations dangling i3c_hci_of_match appears
which compiler will warn about.
> + .acpi_match_table = i3c_hci_acpi_match,
> },
> };
--
With Best Regards,
Andy Shevchenko